treewide: fix various bugs w/ OpenSSL 3+ EVP API
commite0b8c84240037a592c5bd5f18fc382a98a323bea
authorEric Wong <e@80x24.org>
Fri, 1 Sep 2023 02:09:28 +0000 (1 02:09 +0000)
committerJunio C Hamano <gitster@pobox.com>
Fri, 1 Sep 2023 05:26:01 +0000 (31 22:26 -0700)
treede19a4b26a3eca5f83892735cb28aec3223be147
parentbda9c12073e786e2ffa2c3ec479c7fe098d49999
treewide: fix various bugs w/ OpenSSL 3+ EVP API

The OpenSSL 3+ EVP API for SHA-* cannot support our prior use cases
supported by other SHA-* implementations.  It has the following
differences:

1. ->init_fn is required before all use
2. struct assignments don't work and requires ->clone_fn
3. can't support ->update_fn after ->final_*fn

While fixing cases 1 and 2 is merely the matter of calling ->init_fn and
->clone_fn as appropriate, fixing case 3 requires calling ->final_*fn on
a temporary context that's cloned from the primary context.

Reported-by: Bagas Sanjaya <bagasdotme@gmail.com>
Link: https://lore.kernel.org/ZPCL11k38PXTkFga@debian.me/
Helped-by: brian m. carlson <sandals@crustytoothpaste.net>
Fixes: 3e440ea0aba0 ("sha256: avoid functions deprecated in OpenSSL 3+")
Fixes: bda9c12073e7 ("avoid SHA-1 functions deprecated in OpenSSL 3+")
Signed-off-by: Eric Wong <e@80x24.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/fast-import.c
builtin/index-pack.c
builtin/unpack-objects.c
bulk-checkin.c
csum-file.c