| commit | d2ce10d7b7d67ff8b50ae749ce4c5b1a2b8d133c | |
| author | Jakub Narebski <jnareb@gmail.com> | |
| Tue, 9 Dec 2008 22:48:51 +0000 (9 23:48 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 10 Dec 2008 08:21:05 +0000 (10 00:21 -0800) | ||
| tree | 4d49149e53dfcee38172618a894f5af1f0ec4ae1 | treesnapshot (tar.gz zip) |
| parent | 4a24bfc22081a6c2771b62d464222f81c470192c | commitdiff |
gitweb: A bit of code cleanup in git_blame()
Among others, here are the highlights:
* move variable declaration closer to the place it is set and used,
if possible,
* uniquify and simplify coding style a bit, which includes removing
unnecessary '()'.
* check type only if $hash was defined, as otherwise from the way
git_get_hash_by_path() is called (and works), we know that it is
a blob,
* use modern calling convention for git-blame,
* remove unused variable,
* don't use implicit variables ($_),
* add some comments
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Acked-by: Luben Tuikov <ltuikov@yahoo.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Among others, here are the highlights:
* move variable declaration closer to the place it is set and used,
if possible,
* uniquify and simplify coding style a bit, which includes removing
unnecessary '()'.
* check type only if $hash was defined, as otherwise from the way
git_get_hash_by_path() is called (and works), we know that it is
a blob,
* use modern calling convention for git-blame,
* remove unused variable,
* don't use implicit variables ($_),
* add some comments
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Acked-by: Luben Tuikov <ltuikov@yahoo.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| gitweb/gitweb.perl | diffblobblamehistory |