| commit | c00bfc9d1be8ae45c4d321b1cb02f146ce670f33 | |
| author | Johannes Sixt <j6t@kdbg.org> | |
| Mon, 5 Sep 2016 19:00:47 +0000 (5 21:00 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 7 Sep 2016 18:35:08 +0000 (7 11:35 -0700) | ||
| tree | 2f3a30997c6ce969ef7de8aa54bc75e7061e4f10 | treesnapshot (tar.gz zip) |
| parent | e0c1ceafc5bece92d35773a75fff59497e1d9bd5 | commitdiff |
t9903: fix broken && chain
We might wonder why our && chain check does not catch this case:
The && chain check uses a strange exit code with the expectation that
the second or later part of a broken && chain would not exit with this
particular code.
This expectation does not work in this case because __git_ps1, being
the first command in the second part of the broken && chain, records
the current exit code, does its work, and finally returns to the caller
with the recorded exit code. This fools our && chain check.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
We might wonder why our && chain check does not catch this case:
The && chain check uses a strange exit code with the expectation that
the second or later part of a broken && chain would not exit with this
particular code.
This expectation does not work in this case because __git_ps1, being
the first command in the second part of the broken && chain, records
the current exit code, does its work, and finally returns to the caller
with the recorded exit code. This fools our && chain check.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t9903-bash-prompt.sh | diffblobblamehistory |