| commit | 87f16258367a3b9a62663b11f898a4a6f3c19d31 | |
| author | Ramsay Jones <ramsay@ramsayjones.plus.com> | |
| Fri, 4 Mar 2016 23:10:50 +0000 (4 23:10 +0000) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 4 Mar 2016 23:51:08 +0000 (4 15:51 -0800) | ||
| tree | bddc97adb9ea88ef2a5bfee29b172b087041e8cb | treesnapshot (tar.gz zip) |
| parent | 5cd6978a9cfef58de061a9525f3678ade479564d | commitdiff |
xdiff/xprepare: fix a memory leak
The xdl_prepare_env() function may initialise an xdlclassifier_t
data structure via xdl_init_classifier(), which allocates memory
to several fields, for example 'rchash', 'rcrecs' and 'ncha'.
If this function later exits due to the failure of xdl_optimize_ctxs(),
then this xdlclassifier_t structure, and the memory allocated to it,
is not cleaned up.
In order to fix the memory leak, insert a call to xdl_free_classifier()
before returning.
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The xdl_prepare_env() function may initialise an xdlclassifier_t
data structure via xdl_init_classifier(), which allocates memory
to several fields, for example 'rchash', 'rcrecs' and 'ncha'.
If this function later exits due to the failure of xdl_optimize_ctxs(),
then this xdlclassifier_t structure, and the memory allocated to it,
is not cleaned up.
In order to fix the memory leak, insert a call to xdl_free_classifier()
before returning.
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| xdiff/xprepare.c | diffblobblamehistory |