t7006: replace dubious test
commit551d535d721839dedc6e376b12f3adeada8542b4
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Fri, 3 Mar 2017 17:32:01 +0000 (3 18:32 +0100)
committerJunio C Hamano <gitster@pobox.com>
Fri, 3 Mar 2017 21:18:02 +0000 (3 13:18 -0800)
tree2f459d23700518c86b4fc71ac56a9032b125f7ea
parente7e07d5a4fcc2a203d9873968ad3e6bd4d7419d7
t7006: replace dubious test

The idea of the test case "git -p - core.pager is not used from
subdirectory" was to verify that the setup_git_directory() function had
not been called just to obtain the core.pager setting.

However, we are about to fix the early config machinery so that it
*does* work, without messing up the global state.

Once that is done, the core.pager setting *will* be used, even when
running from a subdirectory, and that is a Good Thing.

The intention of that test case, however, was to verify that the
setup_git_directory() function has not run, because it changes global
state such as the current working directory.

To keep that spirit, but fix the incorrect assumption, this patch
replaces that test case by a new one that verifies that the pager is
run in the subdirectory, i.e. that the current working directory has
not been changed at the time the pager is configured and launched, even
if the `rev-parse` command requires a .git/ directory and *will* change
the working directory.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t7006-pager.sh