| commit | 4b580061b350ae9d27ab7c3936a45828a33624c6 | |
| author | Neil Horman <nhorman@tuxdriver.com> | |
| Thu, 3 May 2012 12:10:22 +0000 (3 08:10 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 3 May 2012 22:41:35 +0000 (3 15:41 -0700) | ||
| tree | 2a1bf8aca353514402c77d72f61047562a90e34c | treesnapshot (tar.gz zip) |
| parent | 90e1818f9a06015159712e204dd90868e0a6c421 | commitdiff |
git cherry-pick: do not dereference a potential NULL pointer
In the case the pointer could be NULL, the function that gave the caller
the NULL pointer would already have issued an error message, so simply
returning early with an error status without issuing a new message is
sufficient. The same for parse_commit() that will show necessary error
message when the argument is not NULL, and will return error silently
when the argument is NULL.
Noticed-by: Michael Mueller
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In the case the pointer could be NULL, the function that gave the caller
the NULL pointer would already have issued an error message, so simply
returning early with an error status without issuing a new message is
sufficient. The same for parse_commit() that will show necessary error
message when the argument is not NULL, and will return error silently
when the argument is NULL.
Noticed-by: Michael Mueller
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| sequencer.c | diffblobblamehistory |