| commit | 2b15846dbfb31df10a69a4d56ae944a01563bc07 | |
| author | Jeff King <peff@peff.net> | |
| Mon, 24 Feb 2014 07:49:05 +0000 (24 02:49 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 24 Feb 2014 18:12:58 +0000 (24 10:12 -0800) | ||
| tree | 22f680d01100b90ecec09f40d7f442d11d89024f | treesnapshot (tar.gz zip) |
| parent | 1dca155fe3fac29e847d2d8ff1087d892a129a9c | commitdiff |
log: do not segfault on gmtime errors
Many code paths assume that show_date and show_ident_date
cannot return NULL. For the most part, we handle missing or
corrupt timestamps by showing the epoch time t=0.
However, we might still return NULL if gmtime rejects the
time_t we feed it, resulting in a segfault. Let's catch this
case and just format t=0.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Many code paths assume that show_date and show_ident_date
cannot return NULL. For the most part, we handle missing or
corrupt timestamps by showing the epoch time t=0.
However, we might still return NULL if gmtime rejects the
time_t we feed it, resulting in a segfault. Let's catch this
case and just format t=0.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| date.c | diffblobblamehistory | |
| t/t4212-log-corrupt.sh | diffblobblamehistory |