From efd33565cf38973e8abc8dcd180f60710cfc7eb1 Mon Sep 17 00:00:00 2001 From: "Kyle J. McKay" Date: Sat, 17 Sep 2016 16:30:41 -0700 Subject: [PATCH] Config.pm: switch GitHub from git: to https: In 1b75a119ab39 (Config.pm: modernize config example settings, 2016-03-29), the mirror source for GitHub was switched from git: to https: on the master branch, but git: was retained on the rorcz branch. There's no good reason to retain the git: scheme when setting up GitHub mirrors and several good reasons to switch to https: * Should GitHub support redirects (perhaps in the case of a project rename), they can be followed whereas git: has no redirects. * We set a low speed timeout limit via cURL for http:/https: fetch but do not have such a thing available for git: so the full jobd.pl job timeout must expire for git: fetches that hang but not http:/https:. * The https: scheme is secure from unwanted interference whereas the git: scheme is not. Therefore switch the GitHub mirror source from git: to https: to match what's on the master branch. Signed-off-by: Kyle J. McKay --- Girocco/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Girocco/Config.pm b/Girocco/Config.pm index 1c012fd..32b3c98 100644 --- a/Girocco/Config.pm +++ b/Girocco/Config.pm @@ -591,7 +591,7 @@ our $mirror_sources = [ }, { label => 'GitHub', - url => 'git://github.com/%1/%2.git', + url => 'https://github.com/%1/%2.git', desc => 'GitHub Social Code Hosting', link => 'http://github.com/', inputs => [ { label => 'User:' }, { label => 'Project:', suffix => '.git' } ] -- 2.11.4.GIT