From 6fd5b0f80bba929ca7faff42dbfe8c1d05c54df5 Mon Sep 17 00:00:00 2001 From: Petr Baudis Date: Thu, 5 Nov 2009 00:44:27 +0100 Subject: [PATCH] Girocco::Project: Clean up gitconfig properties support, fix missing chomp there --- Girocco/Project.pm | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/Girocco/Project.pm b/Girocco/Project.pm index 9ac71c0..cabd1ae 100644 --- a/Girocco/Project.pm +++ b/Girocco/Project.pm @@ -52,9 +52,13 @@ sub _property_fget { my $pname = $propmap{$name}; $pname or die "unknown property: $name"; if ($pname =~ s/^://) { - return `git --git-dir="$self->{path}" config "gitweb.$pname"` + my $val = `git --git-dir="$self->{path}" config "gitweb.$pname"`; + chomp $val; + return $val; } elsif ($pname =~ s/^%//) { - return `git --git-dir="$self->{path}" config "$pname"` + my $val = `git --git-dir="$self->{path}" config "$pname"`; + chomp $val; + return $val; } open P, $self->_property_path($pname) or return undef; @@ -71,9 +75,9 @@ sub _property_fput { $pname or die "unknown property: $name"; $value ||= ''; if ($pname =~ s/^://) { - return `git --git-dir="$self->{path}" config "gitweb.$pname" "$value"` + system('git', '--git-dir='.$self->{path}, 'config', "gitweb.$pname", $value); } elsif ($pname =~ s/^%//) { - return `git --git-dir="$self->{path}" config "$pname" "$value"` + system('git', '--git-dir='.$self->{path}, 'config', $pname, $value); } my $P = lock_file($self->_property_path($pname)); -- 2.11.4.GIT