From dcad805d5418cc00c9aea7eb28b4a1c16c23c18c Mon Sep 17 00:00:00 2001
From: "Kyle J. McKay" <mackyle@gmail.com>
Date: Wed, 17 Sep 2014 07:01:19 -0700
Subject: [PATCH] mirrorproj.cgi: do not clone project again

Since 6a6d238a regproj.cgi actually initiates the clone to avoid
having the clone initiation fall through the cracks.

Having mirrorproj.cgi do it again can lead to multiple clone
attempts for the same project.

Also since mirrorproj.cgi does not require a password having
it able to initiate a clone is bad.

So remove the $proj->clone call from mirrorproj.cgi to prevent
double clones and malicious use.
---
 cgi/mirrorproj.cgi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/cgi/mirrorproj.cgi b/cgi/mirrorproj.cgi
index 780343d..09b1a24 100755
--- a/cgi/mirrorproj.cgi
+++ b/cgi/mirrorproj.cgi
@@ -52,7 +52,6 @@ if (!$proj->{clone_logged} or $proj->{clone_failed}) {
 	# Kick off the clone since it is not running yet
 	print "<p>Initiated mirroring of ".$proj->{url}." to $Girocco::Config::name project ".
 		"<a href=\"@{[url_path($Girocco::Config::gitweburl)]}/$name.git\">$name</a>.git:</p>\n";
-	$proj->clone;
 
 } elsif ($proj->{clone_in_progress}) {
 	print "<p>Mirroring of ".$proj->{url}." to $Girocco::Config::name project ".
-- 
2.11.4.GIT