From c7070c506f42e59cf71bb96fc85517ac5406ded5 Mon Sep 17 00:00:00 2001 From: "Kyle J. McKay" Date: Tue, 28 Jan 2014 21:23:26 -0800 Subject: [PATCH] mail.sh: clean up a few minor issues Be clear that a normal end to the script has status 0 by adding an explicit "exit 0". Remove superfluous blank lines that do not belong in the warning messages. --- taskd/mail.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/taskd/mail.sh b/taskd/mail.sh index e25f06f..beeb3fd 100755 --- a/taskd/mail.sh +++ b/taskd/mail.sh @@ -146,7 +146,6 @@ prep_for_email() short_refname=${refname##refs/remotes/} echo >&2 "*** Push-update of tracking branch, $refname" echo >&2 "*** - no email generated." - echo "" return 1 ;; refs/mob/*,commit|refs/mob/*,tag) @@ -155,14 +154,12 @@ prep_for_email() short_refname=${refname##refs/mob/} echo >&2 "*** Push-update of personal mob ref, $refname" echo >&2 "*** - no email generated." - echo "" return 1 ;; *) # Anything else (is there anything else?) echo >&2 "*** Unknown type of update to $refname ($rev_type)" echo >&2 "*** - no email generated" - echo "" return 1 ;; esac @@ -179,7 +176,6 @@ prep_for_email() esac echo >&2 "*** $config_name is not set so no email will be sent" echo >&2 "*** for $refname update $oldrev->$newrev" - echo "" return 1 fi @@ -779,3 +775,5 @@ else PAGER= generate_email | size_limit $((256*1024)) | send_mail done fi + +exit 0 -- 2.11.4.GIT