From 0806c85a5b90d9d15eeacdaf40afee57af4294a3 Mon Sep 17 00:00:00 2001
From: "Kyle J. McKay" <mackyle@gmail.com>
Date: Mon, 2 Mar 2015 00:53:50 -0800
Subject: [PATCH] taskd.pl: switch to 3-arg form of open

The 3-argument form of open is safer and never invokes the shell.
---
 taskd/taskd.pl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/taskd/taskd.pl b/taskd/taskd.pl
index 4bc2c08..7940780 100755
--- a/taskd/taskd.pl
+++ b/taskd/taskd.pl
@@ -94,10 +94,10 @@ sub clone {
 	$proj->{clone_in_progress} or die "project $name is not marked for cloning";
 	$proj->{clone_logged} and die "project $name is already being cloned";
 	print STDERR "cloning $name\n";
-	open STDOUT, ">".$Girocco::Config::reporoot."/".$name.".git/.clonelog" or die "cannot open clonelog: $!";
+	open STDOUT, '>', "$Girocco::Config::reporoot/$name.git/.clonelog" or die "cannot open clonelog: $!";
 	open STDERR, ">&STDOUT";
-	open STDIN, "</dev/null";
-	exec $Girocco::Config::basedir.'/taskd/clone.sh', "$name.git" or die "exec failed: $!";
+	open STDIN, '<', '/dev/null';
+	exec "$Girocco::Config::basedir/taskd/clone.sh", "$name.git" or die "exec failed: $!";
 }
 
 sub ref_change {
@@ -114,7 +114,7 @@ sub ref_change {
 	}
 
 	print STDERR "ref-change $username $name ($ref: $oldrev -> $newrev)\n";
-	open STDIN, "</dev/null";
+	open STDIN, '<', '/dev/null';
 	Girocco::Notify::ref_change($proj, $user, $ref, $oldrev, $newrev);
 	return 0;
 }
-- 
2.11.4.GIT