From 73ec90e1fe496a795e6fb6c90905173cb8d24616 Mon Sep 17 00:00:00 2001
From: Paul Bone <pbone@mozilla.com>
Date: Thu, 4 May 2023 06:46:25 +0000
Subject: [PATCH] Bug 1828599 - Assert if mprotect/VirtualFree fails r=glandium

Differential Revision: https://phabricator.services.mozilla.com/D175834
---
 memory/replace/phc/PHC.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/memory/replace/phc/PHC.cpp b/memory/replace/phc/PHC.cpp
index bfcfe6e254ff..7693499ae084 100644
--- a/memory/replace/phc/PHC.cpp
+++ b/memory/replace/phc/PHC.cpp
@@ -1167,14 +1167,15 @@ static void FreePage(GMutLock aLock, uintptr_t aIndex,
                      const Maybe<arena_id_t>& aArenaId,
                      const StackTrace& aFreeStack, Delay aReuseDelay) {
   void* pagePtr = gConst->AllocPagePtr(aIndex);
+
 #ifdef XP_WIN
   if (!VirtualFree(pagePtr, kPageSize, MEM_DECOMMIT)) {
-    return;
+    MOZ_CRASH("VirtualFree failed");
   }
 #else
   if (mmap(pagePtr, kPageSize, PROT_NONE, MAP_FIXED | MAP_PRIVATE | MAP_ANON,
            -1, 0) == MAP_FAILED) {
-    return;
+    MOZ_CRASH("mmap failed");
   }
 #endif
 
-- 
2.11.4.GIT