| commit | 3643d41bc416bce1d2e704eed32d804add1b0c46 | |
| author | Karl Tomlinson <karlt+@karlt.net> | |
| Thu, 18 Jan 2024 02:03:23 +0000 (18 02:03 +0000) | ||
| committer | Karl Tomlinson <karlt+@karlt.net> | |
| Thu, 18 Jan 2024 02:03:23 +0000 (18 02:03 +0000) | ||
| tree | d3af18dbc3ff25776ee16e87717515f5b5b03e8f | treesnapshot (tar.gz zip) |
| parent | 05d687e03817f3cd0324fe030e21f27355839b9e | commitdiff |
Bug 1872787 change non-fatal MediaTrackGraph shutdown assertion to MOZ_DIAGNOSTIC_ASSERT r=padenot
If the graph leaks because it does not shut down its driver, then an nsThread
can be leaked and block shutdown at nsThreadManager::ShutdownNonMainThreads().
The shutdown blocker has better debug messages to identify the source of the
blockage than ShutdownNonMainThreads(), so I'd like to remove
MediaTrackGraph's code that removes it's shutdown blocker after a timeout.
This new assert is intended to give some visibility into how many problems
such removal might cause.
Depends on D198769
Differential Revision: https://phabricator.services.mozilla.com/D198770
If the graph leaks because it does not shut down its driver, then an nsThread
can be leaked and block shutdown at nsThreadManager::ShutdownNonMainThreads().
The shutdown blocker has better debug messages to identify the source of the
blockage than ShutdownNonMainThreads(), so I'd like to remove
MediaTrackGraph's code that removes it's shutdown blocker after a timeout.
This new assert is intended to give some visibility into how many problems
such removal might cause.
Depends on D198769
Differential Revision: https://phabricator.services.mozilla.com/D198770
| dom/media/MediaTrackGraph.cpp | diffblobblamehistory |