| commit | 65097208df76439f0f059bafad5945624131475b | |
| author | elextr <elextr@gmail.com> | |
| Sat, 13 Jan 2018 05:03:22 +0000 (13 15:03 +1000) | ||
| committer | Matthew Brush <mbrush@codebrainz.ca> | |
| Sat, 13 Jan 2018 05:03:22 +0000 (12 21:03 -0800) | ||
| tree | fe71ffa878ba709798015fbbb24389a84ea1106d | treesnapshot (tar.gz zip) |
| parent | cc035ab99db99996d6667957a1a15cc93a555f2d | commitdiff |
TravisCI: Remove requirement to fail build on aggregate return (#1740)
Returning large aggregates as values is a potential performance problem, but preventing all aggregate returns is inappropriate because:
1. returning small aggregates that are mostly handled as complete objects as return values often makes code clearer.
2. Modern (well not so modern actually) ABIs allow for small aggregates to be returned in registers, so forcing all returns to memory is actually likely to be slower.
3. if code review does not notice a large aggregate return and nobody notices a performance issue then it doesn't matter
Returning large aggregates as values is a potential performance problem, but preventing all aggregate returns is inappropriate because:
1. returning small aggregates that are mostly handled as complete objects as return values often makes code clearer.
2. Modern (well not so modern actually) ABIs allow for small aggregates to be returned in registers, so forcing all returns to memory is actually likely to be slower.
3. if code review does not notice a large aggregate return and nobody notices a performance issue then it doesn't matter
| .travis.yml | diffblobblamehistory |