From d1b7d7dbcbb5a3afbe87407030b637cfb9f9309d Mon Sep 17 00:00:00 2001
From: Benedikt Neuffer <github@itfriend.de>
Date: Fri, 12 Sep 2014 21:35:39 +0200
Subject: [PATCH] check exit of codes included shell commands

WARNING This Change may break your current setup!
---
 NEWS         | 1 +
 doc/ferm.pod | 2 ++
 src/ferm     | 3 +++
 3 files changed, 6 insertions(+)

diff --git a/NEWS b/NEWS
index fd752e6..7679aa1 100644
--- a/NEWS
+++ b/NEWS
@@ -10,6 +10,7 @@
 v2.2.1 - not yet released
   - support netfilter modules:
     * CHECKSUM
+  - check exit of codes included shell commands WARNING may break your current setup!
 
 
 v2.2 - 1 Jul 2013
diff --git a/doc/ferm.pod b/doc/ferm.pod
index 07d247f..a47e8fe 100644
--- a/doc/ferm.pod
+++ b/doc/ferm.pod
@@ -1579,6 +1579,8 @@ parses its output:
 
     @include '/root/generate_ferm_rules.sh $HOSTNAME|'
 
+B<ferm> aborts, if return code is not 0.
+
 =head2 Conditionals
 
 The keyword B<@if> introduces a conditional expression:
diff --git a/src/ferm b/src/ferm
index 8e13440..9b0e7b9 100755
--- a/src/ferm
+++ b/src/ferm
@@ -1947,6 +1947,9 @@ sub enter($$) {
                     # parse the script
                     enter($lev + 1, \%rule);
 
+                    #check for exit status
+                    error("'$script->{filename}': exit status is not 0") if not close $script->{handle};
+
                     # pop stack
                     shift @stack;
                     die unless @stack == $old_stack_depth;
-- 
2.11.4.GIT