From e3f00f5637a2790923a9c4c1d4b7dbf65027d8ce Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Tue, 22 May 2018 20:08:01 -0400 Subject: [PATCH] Clarify when to use advice-add vs add-function * lisp/emacs-lisp/nadvice.el (add-function): Note in docstring that advice-add should be used for named functions. --- lisp/emacs-lisp/nadvice.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el index e2e68250575..e20cc6570db 100644 --- a/lisp/emacs-lisp/nadvice.el +++ b/lisp/emacs-lisp/nadvice.el @@ -288,6 +288,9 @@ a special meaning: If PLACE is a symbol, its `default-value' will be affected. Use (local \\='SYMBOL) if you want to apply FUNCTION to SYMBOL buffer-locally. Use (var VAR) if you want to apply FUNCTION to the (lexical) VAR. +If you are trying to modify an existing named function rather +than a function value, you probably want to use `advice-add' +instead (see Info node `(elisp) Advising Named Functions'). If one of FUNCTION or OLDFUN is interactive, then the resulting function is also interactive. There are 3 cases: -- 2.11.4.GIT