From 2e1702146da802b5760acc4cdfd543e317468f2b Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Thu, 14 Aug 2008 16:12:19 -0700 Subject: [PATCH] Paper bag fix 'jgit glog' handling of commit-ish arguments When we parsed these arguments into RevCommit instances they were done against the wrong RevWalk instance. We parsed them into a generic RevWalk which has no plotting support, so the objects do not have the extra fields used by the plotting code. We need to lookup the commit from the PlotRevWalk and use those instances. One of the calls (markStart) failed to use the secondary RevWalk instance, resulting in a ClassCastException during plotting. Signed-off-by: Shawn O. Pearce --- org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java index 97fe7a49..338af407 100644 --- a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java +++ b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java @@ -152,7 +152,7 @@ abstract class RevWalkTextBuiltin extends TextBuiltin { if (c.has(RevFlag.UNINTERESTING)) walk.markUninteresting(real); else - walk.markStart(c); + walk.markStart(real); } final long start = System.currentTimeMillis(); -- 2.11.4.GIT