From b835da91257e84fb2883b7a799bf9701423b2afe Mon Sep 17 00:00:00 2001
From: Mathias Kinzler <mathias.kinzler@sap.com>
Date: Fri, 11 Jun 2010 08:26:04 +0200
Subject: [PATCH] Wrong warning message in SourceBranchPage

Symptom:
In the clone wizard (Git Repositories -> Clone a Git repository) paste a
local folder which does not contain a repo and press next. Now there is a
message "Source Git Repository is empty".
Now go back, correct the path and press next again. The message is still
there.

Bug: 314616
Change-Id: I487872818e02486880f29946c4eb7367f1740fab
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
---
 .../src/org/eclipse/egit/ui/internal/clone/SourceBranchPage.java | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/SourceBranchPage.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/SourceBranchPage.java
index e1af8973..eff66a2c 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/SourceBranchPage.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/SourceBranchPage.java
@@ -55,12 +55,10 @@ class SourceBranchPage extends BaseWizardPage {
 
 	private Ref head;
 
-	private List<Ref> availableRefs = new ArrayList<Ref>();
+	private final List<Ref> availableRefs = new ArrayList<Ref>();
 
 	private List<Ref> selectedRefs = new ArrayList<Ref>();
 
-	private boolean sourceRepoEmpty = false;
-
 	private Label label;
 
 	private Table refsTable;
@@ -92,7 +90,7 @@ class SourceBranchPage extends BaseWizardPage {
 	}
 
 	boolean isSourceRepoEmpty() {
-		return sourceRepoEmpty;
+		return availableRefs.isEmpty();
 	}
 
 	boolean isAllSelected() {
@@ -190,6 +188,7 @@ class SourceBranchPage extends BaseWizardPage {
 	 * called only when all necessary data from previous form is available.
 	 */
 	private void checkPage() {
+		setMessage(null);
 		if (transportError != null) {
 			setErrorMessage(transportError);
 			setPageComplete(false);
@@ -303,8 +302,6 @@ class SourceBranchPage extends BaseWizardPage {
 			ti.setChecked(true);
 			selectedRefs.add(r);
 		}
-		if (availableRefs.size() == 0)
-			sourceRepoEmpty = true;
 		notifySelectionChanged();
 		checkPage();
 	}
-- 
2.11.4.GIT