| commit | 96d430a13d0e9210ccf563d42ba94c202d578d18 | |
| author | Thomas Wolf <thomas.wolf@paranor.ch> | |
| Fri, 29 Jun 2018 15:05:33 +0000 (29 17:05 +0200) | ||
| committer | Thomas Wolf <thomas.wolf@paranor.ch> | |
| Thu, 5 Jul 2018 17:20:35 +0000 (5 19:20 +0200) | ||
| tree | e8448780a20dc206f531eaf8af5becb6d164bad9 | treesnapshot (tar.gz zip) |
| parent | f25e7c92b13fc6517da3d78315489a19b57328d7 | commitdiff |
Fix error marker updates in staging view
Use (absolute) paths instead of resources to determine which elements
to update in the staging viewer. Using resources may give inconsistent
results if
* a file occurs several times in the Eclipse resource tree, or
* a on-disk directory doesn't exist as a resource in Eclipse at all.
The latter can occur if tree representation is used and an Eclipse
project lives in some sub-directory (for instance, "bundles") in the
git working tree. In that case the staging view will have a folder
"bundles", but there's no resource for it, and thus our top-down
tree traversal will skip it and all its descendants.
Bug: 536471
Change-Id: I46fc84737471e2994af056ecb238b3bbfb55e413
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
Use (absolute) paths instead of resources to determine which elements
to update in the staging viewer. Using resources may give inconsistent
results if
* a file occurs several times in the Eclipse resource tree, or
* a on-disk directory doesn't exist as a resource in Eclipse at all.
The latter can occur if tree representation is used and an Eclipse
project lives in some sub-directory (for instance, "bundles") in the
git working tree. In that case the staging view will have a folder
"bundles", but there's no resource for it, and thus our top-down
tree traversal will skip it and all its descendants.
Bug: 536471
Change-Id: I46fc84737471e2994af056ecb238b3bbfb55e413
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
| org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/decorators/ProblemLabelDecorator.java | diffblobblamehistory |