| commit | 7723b585c0bebdff7696a288004304f8f7a3c0c0 | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Thu, 26 Mar 2009 19:42:47 +0000 (26 12:42 -0700) | ||
| committer | Robin Rosenberg <robin.rosenberg@dewire.com> | |
| Thu, 26 Mar 2009 21:06:23 +0000 (26 22:06 +0100) | ||
| tree | 5a1e4ecbed2cc67bcfab9c4d417c48ae1e54b64c | treesnapshot (tar.gz zip) |
| parent | d0ec86033d2ea990cd2175e17ce0abe3a9df10ee | commitdiff |
Simplify the PackWriter.preparePack() API
It has always bothered me that we had two boolean "mode" parameters
as part of the preparePack method call, when most other options were
set by standard setter methods. In all current callers (except the
unit tests) the ignoreMissingUninteresting was always set to true,
and in many of the callers, packthin was false. Moving these to
setters with a reasonable default simplifies callers considerably.
Signed-off-by: Shawn O. Pearce <sop@google.com>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
It has always bothered me that we had two boolean "mode" parameters
as part of the preparePack method call, when most other options were
set by standard setter methods. In all current callers (except the
unit tests) the ignoreMissingUninteresting was always set to true,
and in many of the callers, packthin was false. Moving these to
setters with a reasonable default simplifies callers considerably.
Signed-off-by: Shawn O. Pearce <sop@google.com>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>