From e8fb65ea9df415bbc7024c38ddbce85c9f353d09 Mon Sep 17 00:00:00 2001 From: Robin Rosenberg Date: Mon, 7 May 2007 23:29:20 +0200 Subject: [PATCH] Recursion and update of all elements regardless of need. When selecting an element in the history view viewer.updateElement is called for every element recursively. If the number of elements is very largs this results in a stack overflow. This only happens with Eclipse 3.3 M7 and not M6. Is it thig bug? https://bugs.eclipse.org/bugs/show_bug.cgi?id=149642 Signed-off-by: Robin Rosenberg Signed-off-by: Shawn O. Pearce --- org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java index 7bc947bf..8be23ec8 100644 --- a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java +++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java @@ -281,6 +281,8 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable, viewer = new TreeViewer(tree, SWT.VIRTUAL | SWT.FULL_SELECTION); + viewer.setUseHashlookup(true); + createColumns(); viewer.setLabelProvider(new GitHistoryLabelProvider()); @@ -354,6 +356,7 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable, } public void updateElement(Object parent, int index) { + System.out.println("updateElement("+parent+","+index); viewer.replace(parent, index, fileRevisions[index]); } } -- 2.11.4.GIT