From 058456865a75ff36d85d63105650d3897ee21105 Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Thu, 11 Feb 2010 15:57:21 -0800 Subject: [PATCH] Fix build and test failures - Correcting versions. [ms: - Correcting wrong version for org.eclipse.core.filesystem to [1.1,2.0) - "Require-Bundle:" needs to use "bundle-version:" to specify version. - Manifest refered to JUnit 4 but test execution specified JUnit 3. - Fix tests which have been broken by the change 667f571b "Fix enabling team operations on project import." - Split packages between org.eclipse.egit.core and org.eclipse.egit.core.test caused ClassNotFoundException in test execution hence moving test packages. ] Change-Id: Ic76335ecb34daa76431b3d7daae566d97a7413f0 Signed-off-by: Shawn O. Pearce Signed-off-by: Matthias Sohn --- org.eclipse.egit-feature/feature.xml | 4 ++-- org.eclipse.egit.core.test/META-INF/MANIFEST.MF | 12 +++++----- .../org.eclipse.egit.core--All-Tests.launch | 2 +- .../T0003_AdaptableFileTreeIteratorTest.java | 8 +++---- .../{ => test}/internal/mapping/T0002_history.java | 4 ++-- .../op/T0001_ConnectProviderOperationTest.java | 6 ++--- org.eclipse.egit.core/META-INF/MANIFEST.MF | 10 ++++---- .../egit/core/op/ConnectProviderOperation.java | 4 ++-- org.eclipse.egit.ui/META-INF/MANIFEST.MF | 28 ++++++++++++---------- 9 files changed, 40 insertions(+), 38 deletions(-) rename org.eclipse.egit.core.test/src/org/eclipse/egit/core/{ => test}/T0003_AdaptableFileTreeIteratorTest.java (93%) rename org.eclipse.egit.core.test/src/org/eclipse/egit/core/{ => test}/internal/mapping/T0002_history.java (98%) rename org.eclipse.egit.core.test/src/org/eclipse/egit/core/{ => test}/op/T0001_ConnectProviderOperationTest.java (96%) diff --git a/org.eclipse.egit-feature/feature.xml b/org.eclipse.egit-feature/feature.xml index 30fd126e..ee62e45b 100644 --- a/org.eclipse.egit-feature/feature.xml +++ b/org.eclipse.egit-feature/feature.xml @@ -26,14 +26,14 @@ - + - + diff --git a/org.eclipse.egit.core.test/META-INF/MANIFEST.MF b/org.eclipse.egit.core.test/META-INF/MANIFEST.MF index 2eb33118..196c2b10 100644 --- a/org.eclipse.egit.core.test/META-INF/MANIFEST.MF +++ b/org.eclipse.egit.core.test/META-INF/MANIFEST.MF @@ -5,12 +5,12 @@ Bundle-Vendor: Eclipse.org Bundle-SymbolicName: org.eclipse.egit.core.test Bundle-Version: 0.6.0.qualifier Bundle-Activator: org.eclipse.egit.core.test.Activator -Require-Bundle: org.eclipse.core.runtime;version="[3.4.0,4.0.0)", - org.eclipse.core.filesystem;version="[3.4.0,4.0.0)", - org.eclipse.core.resources;version="[3.4.0,4.0.0)", - org.eclipse.team.core;version="[3.4.0,4.0.0)", - org.eclipse.jdt.core;version="[3.4.0,4.0.0)", - org.eclipse.jdt.launching;version="[3.4.0,4.0.0)" +Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.4.0,4.0.0)", + org.eclipse.core.filesystem;bundle-version="[1.1.0,2.0.0)", + org.eclipse.core.resources;bundle-version="[3.4.0,4.0.0)", + org.eclipse.team.core;bundle-version="[3.4.0,4.0.0)", + org.eclipse.jdt.core;bundle-version="[3.4.0,4.0.0)", + org.eclipse.jdt.launching;bundle-version="[3.4.0,4.0.0)" Bundle-ActivationPolicy: lazy Import-Package: junit.framework;version="[4.3.1,5.0.0)", org.eclipse.egit.core;version="[0.6.0,0.7.0)", diff --git a/org.eclipse.egit.core.test/org.eclipse.egit.core--All-Tests.launch b/org.eclipse.egit.core.test/org.eclipse.egit.core--All-Tests.launch index 061874a2..82bcb3c1 100644 --- a/org.eclipse.egit.core.test/org.eclipse.egit.core--All-Tests.launch +++ b/org.eclipse.egit.core.test/org.eclipse.egit.core--All-Tests.launch @@ -26,7 +26,7 @@ - + diff --git a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/T0003_AdaptableFileTreeIteratorTest.java b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/T0003_AdaptableFileTreeIteratorTest.java similarity index 93% rename from org.eclipse.egit.core.test/src/org/eclipse/egit/core/T0003_AdaptableFileTreeIteratorTest.java rename to org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/T0003_AdaptableFileTreeIteratorTest.java index 9a52f330..f401b6d9 100644 --- a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/T0003_AdaptableFileTreeIteratorTest.java +++ b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/T0003_AdaptableFileTreeIteratorTest.java @@ -6,7 +6,7 @@ * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/epl-v10.html *******************************************************************************/ -package org.eclipse.egit.core; +package org.eclipse.egit.core.test; import java.io.File; import java.io.FileWriter; @@ -16,10 +16,10 @@ import java.util.Set; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IWorkspaceRoot; +import org.eclipse.egit.core.AdaptableFileTreeIterator; +import org.eclipse.egit.core.ContainerTreeIterator; import org.eclipse.egit.core.op.ConnectProviderOperation; import org.eclipse.egit.core.project.RepositoryMapping; -import org.eclipse.egit.core.test.GitTestCase; -import org.eclipse.jgit.lib.Constants; import org.eclipse.jgit.lib.Repository; import org.eclipse.jgit.treewalk.TreeWalk; import org.eclipse.jgit.treewalk.WorkingTreeIterator; @@ -46,7 +46,7 @@ public class T0003_AdaptableFileTreeIteratorTest extends GitTestCase { fileWriter.close(); final ConnectProviderOperation operation = new ConnectProviderOperation( - project.getProject(), new File("..", Constants.DOT_GIT)); + project.getProject(), gitDir); operation.run(null); } diff --git a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/mapping/T0002_history.java b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/internal/mapping/T0002_history.java similarity index 98% rename from org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/mapping/T0002_history.java rename to org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/internal/mapping/T0002_history.java index e3855bd5..2c748ab2 100644 --- a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/mapping/T0002_history.java +++ b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/internal/mapping/T0002_history.java @@ -7,7 +7,7 @@ * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/epl-v10.html *******************************************************************************/ -package org.eclipse.egit.core.internal.mapping; +package org.eclipse.egit.core.test.internal.mapping; import java.io.File; import java.io.FileWriter; @@ -102,7 +102,7 @@ public class T0002_history extends GitTestCase { assertEquals(RefUpdate.Result.NEW, lck.forceUpdate()); ConnectProviderOperation operation = new ConnectProviderOperation( - project.getProject(), new File("..", Constants.DOT_GIT)); + project.getProject(), gitDir); operation.run(null); } diff --git a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/op/T0001_ConnectProviderOperationTest.java b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/T0001_ConnectProviderOperationTest.java similarity index 96% rename from org.eclipse.egit.core.test/src/org/eclipse/egit/core/op/T0001_ConnectProviderOperationTest.java rename to org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/T0001_ConnectProviderOperationTest.java index 045c4662..593a5246 100644 --- a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/op/T0001_ConnectProviderOperationTest.java +++ b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/T0001_ConnectProviderOperationTest.java @@ -7,7 +7,7 @@ * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/epl-v10.html *******************************************************************************/ -package org.eclipse.egit.core.op; +package org.eclipse.egit.core.test.op; import java.io.ByteArrayInputStream; import java.io.File; @@ -53,7 +53,7 @@ public class T0001_ConnectProviderOperationTest extends GitTestCase { repository.create(); repository.close(); ConnectProviderOperation operation = new ConnectProviderOperation( - project.getProject(), new File("..", Constants.DOT_GIT)); + project.getProject(), gitDir); operation.run(null); assertTrue(RepositoryProvider.isShared(project.getProject())); @@ -95,7 +95,7 @@ public class T0001_ConnectProviderOperationTest extends GitTestCase { assertEquals(RefUpdate.Result.NEW, lck.forceUpdate()); ConnectProviderOperation operation = new ConnectProviderOperation( - project.getProject(), new File("..", Constants.DOT_GIT)); + project.getProject(), gitDir); operation.run(null); final boolean f[] = new boolean[1]; diff --git a/org.eclipse.egit.core/META-INF/MANIFEST.MF b/org.eclipse.egit.core/META-INF/MANIFEST.MF index efd21183..757f06a7 100644 --- a/org.eclipse.egit.core/META-INF/MANIFEST.MF +++ b/org.eclipse.egit.core/META-INF/MANIFEST.MF @@ -6,11 +6,11 @@ Bundle-Version: 0.6.0.qualifier Bundle-Activator: org.eclipse.egit.core.Activator Bundle-Vendor: %provider_name Bundle-Localization: plugin -Require-Bundle: org.eclipse.core.runtime;version="[3.4.0,4.0.0)", - org.eclipse.team.core;version="[3.4.0,4.0.0)", - org.eclipse.core.resources;version="[3.4.0,4.0.0)", - org.eclipse.core.filesystem;version="[3.4.0,4.0.0)", - org.eclipse.ui;version="[3.4.0,4.0.0)" +Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.4.0,4.0.0)", + org.eclipse.team.core;bundle-version="[3.4.0,4.0.0)", + org.eclipse.core.resources;bundle-version="[3.4.0,4.0.0)", + org.eclipse.core.filesystem;bundle-version="[1.2.0,2.0.0)", + org.eclipse.ui;bundle-version="[3.4.0,4.0.0)" Export-Package: org.eclipse.egit.core;version="0.6.0", org.eclipse.egit.core.internal.storage;version="0.6.0";x-friends:="org.eclipse.egit.ui", org.eclipse.egit.core.internal.util;version="0.6.0";x-friends:="org.eclipse.egit.ui", diff --git a/org.eclipse.egit.core/src/org/eclipse/egit/core/op/ConnectProviderOperation.java b/org.eclipse.egit.core/src/org/eclipse/egit/core/op/ConnectProviderOperation.java index 5913f30d..d61a0b37 100644 --- a/org.eclipse.egit.core/src/org/eclipse/egit/core/op/ConnectProviderOperation.java +++ b/org.eclipse.egit.core/src/org/eclipse/egit/core/op/ConnectProviderOperation.java @@ -51,7 +51,7 @@ public class ConnectProviderOperation implements IWorkspaceRunnable { * the project to connect to the Git team provider. */ public ConnectProviderOperation(final IProject proj) { - this(proj, new File(Constants.DOT_GIT)); + this(proj, proj.getLocation().append("/").append(Constants.DOT_GIT).toFile()); } /** @@ -60,7 +60,7 @@ public class ConnectProviderOperation implements IWorkspaceRunnable { * @param proj * the project to connect to the Git team provider. * @param pathToRepo - * relative path to the repository + * absolute path to the repository */ public ConnectProviderOperation(final IProject proj, File pathToRepo) { this.projects.put(proj, pathToRepo); diff --git a/org.eclipse.egit.ui/META-INF/MANIFEST.MF b/org.eclipse.egit.ui/META-INF/MANIFEST.MF index 3035d3bf..8428503d 100644 --- a/org.eclipse.egit.ui/META-INF/MANIFEST.MF +++ b/org.eclipse.egit.ui/META-INF/MANIFEST.MF @@ -6,24 +6,26 @@ Bundle-Version: 0.6.0.qualifier Bundle-Activator: org.eclipse.egit.ui.Activator Bundle-Vendor: %provider_name Bundle-Localization: plugin -Require-Bundle: org.eclipse.core.runtime;version="[3.4.0,4.0.0)", - org.eclipse.core.filesystem;version="[3.4.0,4.0.0)", - org.eclipse.core.resources;version="[3.4.0,4.0.0)", - org.eclipse.core.net;version="[3.4.0,4.0.0)", - org.eclipse.ui;version="[3.4.0,4.0.0)", - org.eclipse.team.core;bundle-version="3.4.0", - org.eclipse.team.ui;version="[3.4.0,4.0.0)", - org.eclipse.jface.text;version="[3.4.0,4.0.0)", - org.eclipse.ui.ide;version="[3.4.0,4.0.0)", - org.eclipse.ui.workbench.texteditor;version="[3.4.0,4.0.0)", - org.eclipse.compare;version="[3.4.0,4.0.0)", - org.eclipse.ui.ide;version="[3.4.0,4.0.0)", - org.eclipse.jsch.ui;bundle-version="1.1.100", +Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.4.0,4.0.0)", + org.eclipse.core.filesystem;bundle-version="[1.1.0,2.0.0)", + org.eclipse.core.resources;bundle-version="[3.4.0,4.0.0)", + org.eclipse.core.net;bundle-version="[1.1.0,2.0.0)", + org.eclipse.ui;bundle-version="[3.4.0,4.0.0)", + org.eclipse.team.core;bundle-version="[3.4.0,4.0.0)", + org.eclipse.team.ui;bundle-version="[3.4.0,4.0.0)", + org.eclipse.jface.text;bundle-version="[3.4.0,4.0.0)", + org.eclipse.ui.ide;bundle-version="[3.4.0,4.0.0)", + org.eclipse.ui.workbench.texteditor;bundle-version="[3.4.0,4.0.0)", + org.eclipse.compare;bundle-version="[3.4.0,4.0.0)", + org.eclipse.ui.ide;bundle-version="[3.4.0,4.0.0)", + org.eclipse.jsch.ui;bundle-version="[1.1.100,2.0.0)", org.eclipse.jsch.core;bundle-version="[1.1.100,2.0.0)" Bundle-ActivationPolicy: lazy Bundle-RequiredExecutionEnvironment: J2SE-1.5 Import-Package: com.jcraft.jsch;version="[0.1.41,0.2.0)", org.eclipse.egit.core;version="[0.6.0,0.7.0)", + org.eclipse.egit.core.internal.storage;version="[0.6.0,0.7.0)", + org.eclipse.egit.core.internal.util;version="[0.6.0,0.7.0)", org.eclipse.egit.core.op;version="[0.6.0,0.7.0)", org.eclipse.egit.core.project;version="[0.6.0,0.7.0)", org.eclipse.jgit.diff;version="0.6.0", -- 2.11.4.GIT