| commit | 92136a31eca6ef4dbbe330dabefbc696b2104045 | |
| author | Remy Suen <remysuen@ca.ibm.com> | |
| Sun, 9 May 2010 14:02:02 +0000 (9 10:02 -0400) | ||
| committer | Remy Suen <remysuen@ca.ibm.com> | |
| Sun, 9 May 2010 14:02:02 +0000 (9 10:02 -0400) | ||
| tree | a44bbe96641e2e789fba04b78e822d3b0088eb9e | treesnapshot (tar.gz zip) |
| parent | 5275585476adf85d8cd88f81ba5f05e04c65b5cf | commitdiff |
Prevent leaking of SWT menus in the 'Git Repositories' view
New instances of SWT menus are currently being instantiated and set
on the tree control every time a user brings up the context menu in
the 'Git Repositories' view. When the tree is disposed, the tree's
menu is also disposed. However, as new menus are instantiated and
set every time, those menus that have been replaced are now lying
around and will only be disposed when the shell itself is disposed.
Change-Id: Ia77bf8cbd8cd3ef27e536821dd979e0882926f44
New instances of SWT menus are currently being instantiated and set
on the tree control every time a user brings up the context menu in
the 'Git Repositories' view. When the tree is disposed, the tree's
menu is also disposed. However, as new menus are instantiated and
set every time, those menus that have been replaced are now lying
around and will only be disposed when the shell itself is disposed.
Change-Id: Ia77bf8cbd8cd3ef27e536821dd979e0882926f44
| org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoriesView.java | diffblobblamehistory |