From afecf0d408a79dbfd47360528895db8512cd41bc Mon Sep 17 00:00:00 2001 From: Didier Verna Date: Wed, 26 Sep 2012 14:57:55 +0200 Subject: [PATCH] Add a comment in Jan Moringen's contrib. --- ...ort-dumping-compressed-executables-in-dump-macro.patch | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/contrib/Support-dumping-compressed-executables-in-dump-macro.patch b/contrib/Support-dumping-compressed-executables-in-dump-macro.patch index 9819bd8..808e592 100644 --- a/contrib/Support-dumping-compressed-executables-in-dump-macro.patch +++ b/contrib/Support-dumping-compressed-executables-in-dump-macro.patch @@ -90,3 +90,18 @@ index 911caf2..9c82637 100644 -- 1.7.0.4 + + Hi Jan! + +Thank you for the patch. What worries me a little is that DUMP was never +really intended to be a universal wrapper around implementation-specific +dumping facilities. Your patch is sort of opening the door to this (who +knows how many vendor options I will need to support in the future?) and +I fear that it may become a Rube Goldberg machine. + +I would rather be enclined to just change it to + +DUMP (NAME FUNCTION &REST ARGS) + +so that ARGS is blindly passed to the underlying implementation. I still +haven't made up my mind completely... -- 2.11.4.GIT