| commit | c641ccac5bd89ce3b908f0939bcb6414d77a2141 | |
| author | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Mon, 2 Oct 2017 12:39:59 +0000 (2 14:39 +0200) | ||
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Mon, 2 Oct 2017 12:40:48 +0000 (2 14:40 +0200) | ||
| tree | d70a8f96c9c1d0b441dc3009d50542a38e4e3cfe | treesnapshot (tar.gz zip) |
| parent | e542728cde676f218c552d841d0af29b92f9800b | commitdiff |
| parent | bb8376bbc3d96af727444f90e5f60d47105609dc | commitdiff |
Merge #11422: qa: Verify DBWrapper iterators are taking snapshots
bb8376b Verify DBWrapper iterators are taking snapshots (Matt Corallo)
Pull request description:
The LevelDB docs seem to indicate that an iterator will not take
snapshots (even providing instructions on how to do so yourself).
In several of the places we use them, we assume snapshots to have
been taken.
In order to make sure LevelDB doesn't change out from under us
(and to prevent the next person who reads the docs from having the
same fright I did), verify that snapshots are taken in our tests.
Tree-SHA512: 54f24dabc294962e9c20882f61809604421a661208d1568bb107102248603e8e7c12e929ccb0812a73d4e4f23fea61f1b48e7cc24da5a7260f1d14d89ba88cd6
bb8376b Verify DBWrapper iterators are taking snapshots (Matt Corallo)
Pull request description:
The LevelDB docs seem to indicate that an iterator will not take
snapshots (even providing instructions on how to do so yourself).
In several of the places we use them, we assume snapshots to have
been taken.
In order to make sure LevelDB doesn't change out from under us
(and to prevent the next person who reads the docs from having the
same fright I did), verify that snapshots are taken in our tests.
Tree-SHA512: 54f24dabc294962e9c20882f61809604421a661208d1568bb107102248603e8e7c12e929ccb0812a73d4e4f23fea61f1b48e7cc24da5a7260f1d14d89ba88cd6