| commit | 81c89e966e1e08c3d94dc9d1d0a26034312c56ff | |
| author | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Tue, 19 Dec 2017 14:53:22 +0000 (19 15:53 +0100) | ||
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Tue, 19 Dec 2017 15:16:39 +0000 (19 16:16 +0100) | ||
| tree | d67a7f18cd6b4a0b3fe54d50a918862264c24337 | treesnapshot (tar.gz zip) |
| parent | 8049241e226c16bd07b029c0cb4b62ac40f0c923 | commitdiff |
| parent | ecf9b25a03d8a29f16005ca4485b6533db6efc82 | commitdiff |
Merge #11923: Wallet : remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx
ecf9b25 remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx (Pierre Rochard)
Pull request description:
The `CWalletDB::FindWalletTx` method was patterned after `CWalletDB::LoadWallet`, where `fNoncriticalErrors` is used when a tx check fails in `ReadKeyValue`.
Since `FindWalletTx` is only used by methods which are zapping txs, it makes sense that `ReadKeyValue` is not called and the tx is not checked, so I think that deleting the unused `fNoncriticalErrors` boolean variable and its conditional statement is appropriate.
Tree-SHA512: 0976eae97522719fdaeca1fb3f4a080561e46c06d0b8dc75e14262c6bc242998db3f7057183a230a1d7e4ac5fc348e9059f545b7d718ebbcdf6dcdfc63bcc286
ecf9b25 remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx (Pierre Rochard)
Pull request description:
The `CWalletDB::FindWalletTx` method was patterned after `CWalletDB::LoadWallet`, where `fNoncriticalErrors` is used when a tx check fails in `ReadKeyValue`.
Since `FindWalletTx` is only used by methods which are zapping txs, it makes sense that `ReadKeyValue` is not called and the tx is not checked, so I think that deleting the unused `fNoncriticalErrors` boolean variable and its conditional statement is appropriate.
Tree-SHA512: 0976eae97522719fdaeca1fb3f4a080561e46c06d0b8dc75e14262c6bc242998db3f7057183a230a1d7e4ac5fc348e9059f545b7d718ebbcdf6dcdfc63bcc286