| commit | 77ba4bf960d315ae826f78b786882757bc89ff59 | |
| author | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Thu, 9 Nov 2017 13:22:22 +0000 (9 14:22 +0100) | ||
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Thu, 9 Nov 2017 13:23:13 +0000 (9 14:23 +0100) | ||
| tree | cf6bf5194d04b398cfef0004e3b6f72683fea85f | treesnapshot (tar.gz zip) |
| parent | ef3758d1ef73f83f7646363f748010cdc5c2d7f2 | commitdiff |
| parent | 5a5e4e9cc19e30186ba0a15a1cf892516d419baf | commitdiff |
Merge #10368: [wallet] Remove helper conversion operator from wallet
5a5e4e9 [wallet] Remove CTransaction&() helper conversion operator from wallet implementation. (Karl-Johan Alm)
Pull request description:
The `CTransaction&()` operator in `CMerkleTx` makes conversion into `CTransaction`s transparent, but was marked as to-be-removed in favor of explicitly getting the `tx` ivar, presumably as the operator can lead to ambiguous behavior and makes the code harder to follow.
This PR removes the operator and adapts callers. This includes some cases of `static_cast<CTransaction>(wtx)` → `*wtx.tx`, which is definitely an improvement.
Tree-SHA512: 95856fec7194d6a79615ea1c322abfcd6bcedf6ffd0cfa89bbdd332ce13035fa52dd4b828d20df673072dde1be64b79c513529a6f422dd5f0961ce722a32d56a
5a5e4e9 [wallet] Remove CTransaction&() helper conversion operator from wallet implementation. (Karl-Johan Alm)
Pull request description:
The `CTransaction&()` operator in `CMerkleTx` makes conversion into `CTransaction`s transparent, but was marked as to-be-removed in favor of explicitly getting the `tx` ivar, presumably as the operator can lead to ambiguous behavior and makes the code harder to follow.
This PR removes the operator and adapts callers. This includes some cases of `static_cast<CTransaction>(wtx)` → `*wtx.tx`, which is definitely an improvement.
Tree-SHA512: 95856fec7194d6a79615ea1c322abfcd6bcedf6ffd0cfa89bbdd332ce13035fa52dd4b828d20df673072dde1be64b79c513529a6f422dd5f0961ce722a32d56a