| commit | 0d7e0a3289baa3b641ca7ab864c5e8af4306f4de | |
| author | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Fri, 1 Dec 2017 14:17:25 +0000 (1 15:17 +0100) | ||
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Fri, 1 Dec 2017 14:19:07 +0000 (1 15:19 +0100) | ||
| tree | adc796ee37727c0d11dc5e5bcd0bd3d3e30c6b62 | treesnapshot (tar.gz zip) |
| parent | 13e31dd6548d64a5992f439e74bb424bf88aca04 | commitdiff |
| parent | b4058ed9c6e1f23720afa0b383c56a9aaed86dcd | commitdiff |
Merge #11337: Fix code constness in CBlockIndex::GetAncestor() overloads
b4058ed Fix code constness in CBlockIndex::GetAncestor() overloads (Dan Raviv)
Pull request description:
Make the non-const overload of `CBlockIndex::GetAncestor()` reuse the const overload implementation instead of the other way around. This way, the constness of the const overload implementation is guaranteed. The other way around, it was possible to implement the non-const overload in a way which mutates the object, and since that implementation would be called even for const objects (due to the reuse), we would get undefined behavior.
Tree-SHA512: 545a8639bc52502ea06dbd924e8fabec6274fa69b43e3b8966a7987ce4dae6fb2498f623730fde7ed0e47478941c7f8baa2e76a12018134ff7c14c0dfa25ba3a
b4058ed Fix code constness in CBlockIndex::GetAncestor() overloads (Dan Raviv)
Pull request description:
Make the non-const overload of `CBlockIndex::GetAncestor()` reuse the const overload implementation instead of the other way around. This way, the constness of the const overload implementation is guaranteed. The other way around, it was possible to implement the non-const overload in a way which mutates the object, and since that implementation would be called even for const objects (due to the reuse), we would get undefined behavior.
Tree-SHA512: 545a8639bc52502ea06dbd924e8fabec6274fa69b43e3b8966a7987ce4dae6fb2498f623730fde7ed0e47478941c7f8baa2e76a12018134ff7c14c0dfa25ba3a
| src/chain.cpp | diff1 | diff2 | blobhistory |