From a08dfa26f0a668f79594dc04a293ca4ddab76be8 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Thu, 14 Dec 2006 02:59:25 +0000 Subject: [PATCH] PR 3704 * bfdio.c (bfd_bread): Don't read past end of archive elements. --- bfd/ChangeLog | 5 +++++ bfd/bfdio.c | 11 ++++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 4a5528633..f15fdd356 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2006-12-14 Alan Modra + + PR 3704 + * bfdio.c (bfd_bread): Don't read past end of archive elements. + 2006-12-12 Daniel Jacobowitz * doc/Makefile.am (bfd_TEXINFOS): Set. diff --git a/bfd/bfdio.c b/bfd/bfdio.c index 0aa82a9d2..0c720f61b 100644 --- a/bfd/bfdio.c +++ b/bfd/bfdio.c @@ -1,7 +1,7 @@ /* Low-level I/O routines for BFDs. Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, - 1999, 2000, 2001, 2002, 2003, 2004, 2005 + 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006 Free Software Foundation, Inc. Written by Cygnus Support. @@ -116,6 +116,15 @@ bfd_bread (void *ptr, bfd_size_type size, bfd *abfd) { size_t nread; + /* If this is an archive element, don't read past the end of + this element. */ + if (abfd->arelt_data != NULL) + { + size_t maxbytes = ((struct areltdata *) abfd->arelt_data)->parsed_size; + if (size > maxbytes) + size = maxbytes; + } + if ((abfd->flags & BFD_IN_MEMORY) != 0) { struct bfd_in_memory *bim; -- 2.11.4.GIT