From 222281c9a7e2bf58c0b2d8960db308d8c24db143 Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Thu, 31 Dec 2009 14:40:36 +0000 Subject: [PATCH] * objcopy.c (add_redefine_syms_file): Avoid symbol buffer overrun. --- binutils/ChangeLog | 6 ++++++ binutils/objcopy.c | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index e0ff3989e..2dfa3b9e1 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,9 @@ +2009-12-31 Eirik Byrkjeflot Anonsen + Nick Clifton + + * objcopy.c (add_redefine_syms_file): Avoid symbol buffer + overrun. + 2009-12-21 Alan Modra * MAINTAINERS: Update my email address. diff --git a/binutils/objcopy.c b/binutils/objcopy.c index 20f867c01..bd8dcec83 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -1232,7 +1232,7 @@ add_redefine_syms_file (const char *filename) filename, strerror (errno)); bufsize = 100; - buf = (char *) xmalloc (bufsize); + buf = (char *) xmalloc (bufsize + 1 /* For the terminating NUL. */); lineno = 1; c = getc (file); @@ -1249,7 +1249,7 @@ add_redefine_syms_file (const char *filename) if (len >= bufsize) { bufsize *= 2; - buf = (char *) xrealloc (buf, bufsize); + buf = (char *) xrealloc (buf, bufsize + 1); } c = getc (file); } @@ -1275,7 +1275,7 @@ add_redefine_syms_file (const char *filename) if (len >= bufsize) { bufsize *= 2; - buf = (char *) xrealloc (buf, bufsize); + buf = (char *) xrealloc (buf, bufsize + 1); } c = getc (file); } -- 2.11.4.GIT