From 0609721bf43c51f010b87d48353c9ffc4f3c4b4b Mon Sep 17 00:00:00 2001 From: iains Date: Wed, 11 Jan 2012 15:24:09 +0000 Subject: [PATCH] bfd: * mach-o.c (bfd_mach_o_build_seg_command): Separate computation of vmsize from filesize. Don't compute offsets or file sizes for zerofill sections. --- bfd/ChangeLog | 6 ++++++ bfd/mach-o.c | 20 ++++++++++++++++---- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 21f137c15..55ccf7e5d 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,5 +1,11 @@ 2012-01-11 Iain Sandoe + * mach-o.c (bfd_mach_o_build_seg_command): Separate computation of + vmsize from filesize. Don't compute offsets or file sizes for + zerofill sections. + +2012-01-11 Iain Sandoe + * mach-o.c (bfd_mach_o_build_commands): Make the building of each command type independent. diff --git a/bfd/mach-o.c b/bfd/mach-o.c index 307a8ebd7..6913b1d92 100644 --- a/bfd/mach-o.c +++ b/bfd/mach-o.c @@ -2023,6 +2023,7 @@ bfd_mach_o_build_seg_command (const char *segment, /* TODO: fix this up for non-MH_OBJECT cases. */ seg->vmaddr = 0; + seg->vmsize = 0; seg->fileoff = mdata->filelen; seg->filesize = 0; @@ -2048,9 +2049,21 @@ bfd_mach_o_build_seg_command (const char *segment, bfd_mach_o_append_section_to_segment (seg, sec); - if (s->size == 0) - s->offset = 0; - else + s->offset = 0; + if (s->size > 0) + { + seg->vmsize = FILE_ALIGN (seg->vmsize, s->align); + seg->vmsize += s->size; + } + + /* Zerofill sections have zero file size & offset, + and are not written. */ + if ((s->flags & BFD_MACH_O_SECTION_TYPE_MASK) == BFD_MACH_O_S_ZEROFILL + || (s->flags & BFD_MACH_O_SECTION_TYPE_MASK) + == BFD_MACH_O_S_GB_ZEROFILL) + continue; + + if (s->size > 0) { mdata->filelen = FILE_ALIGN (mdata->filelen, s->align); s->offset = mdata->filelen; @@ -2062,7 +2075,6 @@ bfd_mach_o_build_seg_command (const char *segment, } seg->filesize = mdata->filelen - seg->fileoff; - seg->vmsize = seg->filesize; return TRUE; } -- 2.11.4.GIT