| commit | 92365dcedd037678087dc55bd91335ea4fbc05cc | |
| author | Chris Frey <cdfrey@foursquare.net> | |
| Fri, 30 Mar 2012 18:50:50 +0000 (30 14:50 -0400) | ||
| committer | Chris Frey <cdfrey@foursquare.net> | |
| Fri, 30 Mar 2012 19:20:22 +0000 (30 15:20 -0400) | ||
| tree | 5c33454a625a471d433f5817022a4aa969c8677f | treesnapshot (tar.gz zip) |
| parent | d2b67c4f180ce82754a68aa6c923c12d753d39f1 | commitdiff |
desktop: fixed segfault issue in StringSync
It is not safe to call Sync() from StringSync's destructor, since if
the destructor is being called as the result of a parent class's
destructor, then we have no guarantee that the external strings
still exist.
This commit removes the destructor call and adds documentation for
this issue.
It is not safe to call Sync() from StringSync's destructor, since if
the destructor is being called as the result of a parent class's
destructor, then we have no guarantee that the external strings
still exist.
This commit removes the destructor call and adds documentation for
this issue.
| desktop/src/StringSync.cc | diffblobblamehistory | |
| desktop/src/StringSync.h | diffblobblamehistory |