From 6d7ac776264d6ce696e194fef59da955871b94bb Mon Sep 17 00:00:00 2001
From: Joerie de Gram <j.de.gram@gmail.com>
Date: Mon, 10 Sep 2007 02:17:10 +0200
Subject: [PATCH] Fixed XSS in login error messages. Resolves FS 7901.

---
 web/html/index.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/web/html/index.php b/web/html/index.php
index 1a182cb..5ff1d52 100644
--- a/web/html/index.php
+++ b/web/html/index.php
@@ -14,10 +14,10 @@ $login_error = "";
 if (isset($_REQUEST["user"]) || isset($_REQUEST["pass"])) {
 	# Attempting to log in
 	#
-	if (!isset($_REQUEST['user'])) {
+	if (!isset($_REQUEST["user"])) {
 		$login_error = __("You must supply a username.");
 	}
-	if (!isset($_REQUEST['pass'])) {
+	if (!isset($_REQUEST["pass"])) {
 		$login_error = __("You must supply a password.");
 	}
 	if (!$login_error) {
@@ -33,12 +33,12 @@ if (isset($_REQUEST["user"]) || isset($_REQUEST["pass"])) {
 		$result = db_query($q, $dbh);
 		if (!$result) {
 			$login_error = __("Error looking up username, %s.",
-						array($_REQUEST["user"]));
+						array(htmlspecialchars($_REQUEST["user"])));
 		} else {
 			$row = mysql_fetch_row($result);
 			if (empty($row)) {
 				$login_error = __("Incorrect password for username, %s.",
-						array($_REQUEST["user"]));
+						array(htmlspecialchars($_REQUEST["user"])));
 			} elseif ($row[1]) {
 				$login_error = __("Your account has been suspended.");
 			}
-- 
2.11.4.GIT