From 100e433741715968b815e4b9fb3e638b625bf472 Mon Sep 17 00:00:00 2001 From: Charles Bailey Date: Fri, 17 Jul 2015 18:09:41 +0100 Subject: [PATCH] untracked: fix detection of uname(2) failure According to POSIX specification uname(2) must return -1 on failure and a non-negative value on success. Although many implementations do return 0 on success it is valid to return any positive value for success. In particular, Solaris returns 1. Signed-off-by: Charles Bailey Reviewed-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dir.c b/dir.c index e9eaf97efe..8d15e475d4 100644 --- a/dir.c +++ b/dir.c @@ -1801,7 +1801,7 @@ static const char *get_ident_string(void) if (sb.len) return sb.buf; - if (uname(&uts)) + if (uname(&uts) < 0) die_errno(_("failed to get kernel name and information")); strbuf_addf(&sb, "Location %s, system %s %s %s", get_git_work_tree(), uts.sysname, uts.release, uts.version); -- 2.11.4.GIT