Revert "prompt: clean up strbuf usage"
commite1c1a324fc7061c8f170a113709724f1640addb3
authorJeff King <peff@peff.net>
Thu, 2 Jan 2014 03:03:30 +0000 (1 22:03 -0500)
committerJunio C Hamano <gitster@pobox.com>
Thu, 2 Jan 2014 18:21:40 +0000 (2 10:21 -0800)
treea53813aaab6449201215bce82a8683b3aa0b0cf2
parentd2446dfd7f3b3f8948142cfb07a0270e2497d93f
Revert "prompt: clean up strbuf usage"

This reverts commit 31b49d9b653803e7c7fd18b21c8bdd86e3421668.

That commit taught do_askpass to hand ownership of our
buffer back to the caller rather than simply return a
pointer into our internal strbuf.  What it failed to notice,
though, was that our internal strbuf is static, because we
are trying to emulate the getpass() interface.

By handing off ownership, we created a memory leak that
cannot be solved. Sometimes git_prompt returns a static
buffer from getpass() (or our smarter git_terminal_prompt
wrapper), and sometimes it returns an allocated string from
do_askpass.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
prompt.c