| commit | d966e6aa66d397908b4fbf69cef2e2da88737321 | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Tue, 8 May 2007 01:13:40 +0000 (7 21:13 -0400) | ||
| committer | Shawn O. Pearce <spearce@spearce.org> | |
| Tue, 8 May 2007 01:13:40 +0000 (7 21:13 -0400) | ||
| tree | 554d22cc5fb86410a8197074ebd67f037cce5634 | treesnapshot (tar.gz zip) |
| parent | 53a58245863eff3d70aaa3ac75d7d57e843fc91d | commitdiff |
Properly handle '0' filenames in import-tars
Randal L. Schwartz pointed out multiple times that we should be
testing the length of the name string here, not if it is "true".
The problem is the string '0' is actually false in Perl when we
try to evaluate it in this context, as '0' is 0 numerically and
the number 0 is treated as a false value. This would cause us
to break out of the import loop early if anyone had a file or
directory named "0".
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Randal L. Schwartz pointed out multiple times that we should be
testing the length of the name string here, not if it is "true".
The problem is the string '0' is actually false in Perl when we
try to evaluate it in this context, as '0' is 0 numerically and
the number 0 is treated as a false value. This would cause us
to break out of the import loop early if anyone had a file or
directory named "0".
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| contrib/fast-import/import-tars.perl | diffblobblamehistory |