Convert many resolve_ref() calls to read_ref*() and ref_exists()
commitc6893323917cbf4cb66c29ba2ac03014a44f0f0c
authorNguyễn Thái Ngọc Duy <pclouds@gmail.com>
Sun, 13 Nov 2011 10:22:14 +0000 (13 17:22 +0700)
committerJunio C Hamano <gitster@pobox.com>
Sun, 13 Nov 2011 20:21:06 +0000 (13 12:21 -0800)
treecc14f88d5ebfd114e5c80f74506eff6c9a5fa68b
parentbc1bbe0c19a6ff39522b4fa3259f34150e308e1f
Convert many resolve_ref() calls to read_ref*() and ref_exists()

resolve_ref() may return a pointer to a static buffer, which is not
safe for long-term use because if another resolve_ref() call happens,
the buffer may be changed.  Many call sites though do not care about
this buffer. They simply check if the return value is NULL or not.

Convert all these call sites to new wrappers to reduce resolve_ref()
calls from 57 to 34. If we change resolve_ref() prototype later on
to avoid passing static buffer out, this helps reduce changes.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 files changed:
builtin/branch.c
builtin/checkout.c
builtin/merge.c
builtin/remote.c
builtin/replace.c
builtin/show-ref.c
builtin/tag.c
bundle.c
cache.h
notes-merge.c
refs.c
remote.c