| commit | be12681896fab9455eb65ea124df423b462e0072 | |
| author | Dan McGee <dpmcgee@gmail.com> | |
| Tue, 18 Oct 2011 05:21:21 +0000 (18 00:21 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 18 Oct 2011 07:16:31 +0000 (18 00:16 -0700) | ||
| tree | 7a4e91fda2ebca5c5b049134152fdf2568d0cad9 | treesnapshot (tar.gz zip) |
| parent | 703f05ad5835cff92b12c29aecf8d724c8c847e2 | commitdiff |
pack-objects: mark add_to_write_order() as inline
This function is a whole 26 bytes when compiled on x86_64, but is
currently invoked over 1.037 billion times when running pack-objects on
the Linux kernel git repository. This is hitting the point where
micro-optimizations do make a difference, and inlining it only increases
the object file size by 38 bytes.
As reported by perf, this dropped task-clock from 84183 to 83373 ms, and
total cycles from 223.5 billion to 221.6 billion. Not astronomical, but
worth getting for adding one word.
Signed-off-by: Dan McGee <dpmcgee@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This function is a whole 26 bytes when compiled on x86_64, but is
currently invoked over 1.037 billion times when running pack-objects on
the Linux kernel git repository. This is hitting the point where
micro-optimizations do make a difference, and inlining it only increases
the object file size by 38 bytes.
As reported by perf, this dropped task-clock from 84183 to 83373 ms, and
total cycles from 223.5 billion to 221.6 billion. Not astronomical, but
worth getting for adding one word.
Signed-off-by: Dan McGee <dpmcgee@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/pack-objects.c | diffblobblamehistory |