| commit | 8ac3a66702c43386eb580b7a1a8b1a31cd675327 | |
| author | Sergey Vlasov <vsu@altlinux.ru> | |
| Sun, 18 Jul 2010 12:17:49 +0000 (18 16:17 +0400) | ||
| committer | Eric Wong <normalperson@yhbt.net> | |
| Mon, 19 Jul 2010 06:31:04 +0000 (19 06:31 +0000) | ||
| tree | 1338314e81762a0de30a65c39e7cb32777f7d33c | treesnapshot (tar.gz zip) |
| parent | 24e7a5be373c95f977bab4f0f41f736bb1d25075 | commitdiff |
git-svn: write memoized data explicitly to avoid Storable bug
Apparently using the Storable module during global destruction is
unsafe - there is a bug which can cause segmentation faults:
http://rt.cpan.org/Public/Bug/Display.html?id=36087
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=482355
The persistent memoization support introduced in commit 8bff7c538
relied on global destruction to write cached data, which was leading
to segfaults in some Perl configurations. Calling Memoize::unmemoize
in the END block forces the cache writeout to be performed earlier,
thus avoiding the bug.
Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Acked-by: Eric Wong <normalperson@yhbt.net>
Apparently using the Storable module during global destruction is
unsafe - there is a bug which can cause segmentation faults:
http://rt.cpan.org/Public/Bug/Display.html?id=36087
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=482355
The persistent memoization support introduced in commit 8bff7c538
relied on global destruction to write cached data, which was leading
to segfaults in some Perl configurations. Calling Memoize::unmemoize
in the END block forces the cache writeout to be performed earlier,
thus avoiding the bug.
Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Acked-by: Eric Wong <normalperson@yhbt.net>
| git-svn.perl | diffblobblamehistory |