| commit | 5d11f794de3c1a5cd592af008a369a90fa30d2e9 | |
| author | Jonathan Nieder <jrnieder@gmail.com> | |
| Sat, 6 Mar 2010 22:58:42 +0000 (6 16:58 -0600) | ||
| committer | Paul Mackerras <paulus@samba.org> | |
| Sat, 20 Mar 2010 09:53:21 +0000 (20 20:53 +1100) | ||
| tree | e0c0e8dd52219622602bb64534ce5d9efc4a4f96 | treesnapshot (tar.gz zip) |
| parent | e7feb695bf93d57c1c5fdf9f2acc2039e3fdf850 | commitdiff |
gitk: Don't clobber "Remember this view" setting
In the View → Edit View... dialog, the "Remember this view" option
always starts out unset. Using the dialog to change an existing view
and ignoring the parts of the dialog that aren’t relevant results in
both the old and new versions of the view being lost.
The cause: right after newviewopts($curview,perm) is set to an
appropriate value, decode_view_opts is clobbering it with the default
value. If that call is moved a little earlier, the "Remember this
view" option gets properly set to its previous value, fixing the
problem.
Reported-by: Steve Cotton <steve0001@s.cotton.clara.co.uk>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
In the View → Edit View... dialog, the "Remember this view" option
always starts out unset. Using the dialog to change an existing view
and ignoring the parts of the dialog that aren’t relevant results in
both the old and new versions of the view being lost.
The cause: right after newviewopts($curview,perm) is set to an
appropriate value, decode_view_opts is clobbering it with the default
value. If that call is moved a little earlier, the "Remember this
view" option gets properly set to its previous value, fixing the
problem.
Reported-by: Steve Cotton <steve0001@s.cotton.clara.co.uk>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
| gitk | diffblobblamehistory |