| commit | 43a61b841d261fe51ac64b55d654677b0cd93ad9 | |
| author | Johan Herland <johan@herland.net> | |
| Thu, 25 Feb 2010 00:48:11 +0000 (25 01:48 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 25 Feb 2010 03:12:48 +0000 (24 19:12 -0800) | ||
| tree | f38eb3bdbc4cbaa8896090c156923bdd3ac209cd | treesnapshot (tar.gz zip) |
| parent | e73bbd96c6e9ce11a101dac03402d0f718a1bd23 | commitdiff |
builtin-notes: Minor (mostly parse_options-related) fixes
Use PARSE_OPT_NONEG to disallow --no-<option> for message, file,
reedit-message and reuse-message. for which --no-<option> does not make
sense. This also simplifies the code in the option-handling callbacks.
Also, use strbuf_addch(... '\n') instead of strbuf_addstr(... "\n") in
couple of places.
Finally, improve the short-help by dividing the options into two
OPT_GROUPs.
Suggested-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Johan Herland <johan@herland.net>
Acked-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Use PARSE_OPT_NONEG to disallow --no-<option> for message, file,
reedit-message and reuse-message. for which --no-<option> does not make
sense. This also simplifies the code in the option-handling callbacks.
Also, use strbuf_addch(... '\n') instead of strbuf_addstr(... "\n") in
couple of places.
Finally, improve the short-help by dividing the options into two
OPT_GROUPs.
Suggested-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Johan Herland <johan@herland.net>
Acked-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin-notes.c | diffblobblamehistory |