| commit | 28bf928cf81eec720bc8a31179a0c9cf688d5af3 | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Wed, 9 May 2007 01:31:31 +0000 (8 21:31 -0400) | ||
| committer | Shawn O. Pearce <spearce@spearce.org> | |
| Wed, 9 May 2007 01:38:54 +0000 (8 21:38 -0400) | ||
| tree | 5434af73a1a67e0648acfd2a0b3dd4979c5769c6 | treesnapshot (tar.gz zip) |
| parent | c74b6c66f00ce51b2c01d20fc5ef0e6429811124 | commitdiff |
git-gui: Don't attempt to inline array reads in methods
If a variable reference to a field is to an array, and it is
the only reference to that field in that method we cannot make
it an inlined [set foo] call as the regexp was converting the
Tcl code wrong. We were producing "[set foo](x)" for "$foo(x)",
and that isn't valid Tcl when foo is an array. So we just punt
if the only occurance has a ( after it.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
If a variable reference to a field is to an array, and it is
the only reference to that field in that method we cannot make
it an inlined [set foo] call as the regexp was converting the
Tcl code wrong. We were producing "[set foo](x)" for "$foo(x)",
and that isn't valid Tcl when foo is an array. So we just punt
if the only occurance has a ( after it.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| lib/class.tcl | diffblobblamehistory |