| commit | 0df49bef95fe1668805cdb76abadfb82a8956b6b | |
| author | Jonathan Nieder <jrnieder@gmail.com> | |
| Fri, 10 Jan 2014 20:10:31 +0000 (10 12:10 -0800) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 10 Jan 2014 23:30:45 +0000 (10 15:30 -0800) | ||
| tree | e86161819d57cf7abdd8ba2af3aeb22fc118f0d1 | treesnapshot (tar.gz zip) |
| parent | 6d8940b562adc5e43068868109dffe1b9bff7f78 | commitdiff |
diff test: reading a directory as a file need not error out
There is no guarantee that strbuf_read_file must error out for
directories. On some operating systems (e.g., Debian GNU/kFreeBSD
wheezy), reading a directory gives its raw content:
$ head -c5 < / | cat -A
^AM-|^_^@^L$
As a result, 'git diff -O/' succeeds instead of erroring out on
these systems, causing t4056.5 "orderfile is a directory" to fail.
On some weird OS it might even make sense to pass a directory to the
-O option and this is not a common user mistake that needs catching.
Remove the test.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
There is no guarantee that strbuf_read_file must error out for
directories. On some operating systems (e.g., Debian GNU/kFreeBSD
wheezy), reading a directory gives its raw content:
$ head -c5 < / | cat -A
^AM-|^_^@^L$
As a result, 'git diff -O/' succeeds instead of erroring out on
these systems, causing t4056.5 "orderfile is a directory" to fail.
On some weird OS it might even make sense to pass a directory to the
-O option and this is not a common user mistake that needs catching.
Remove the test.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t4056-diff-order.sh | diffblobblamehistory |