| commit | 0cb9d6d6b63ad7fea4ca8363f7f1f921b1e16ec7 | |
| author | Jeff King <peff@peff.net> | |
| Thu, 24 Sep 2015 21:07:25 +0000 (24 17:07 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 25 Sep 2015 17:18:18 +0000 (25 10:18 -0700) | ||
| tree | c1d90cc81d90a29a6f110440763f0e4ed91ff5a8 | treesnapshot (tar.gz zip) |
| parent | 495127dbcbd53e89d7edee8db42bfa7e57c8a120 | commitdiff |
upload-archive: convert sprintf to strbuf
When we report an error to the client, we format it into a
fixed-size buffer using vsprintf(). This can't actually
overflow in practice, since we only format a very tame
subset of strings (mostly strerror() output). However, it's
hard to tell immediately, so let's just use a strbuf so
readers do not have to wonder.
We do add an allocation here, but the performance is not
important; the next step is to call die() anyway.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When we report an error to the client, we format it into a
fixed-size buffer using vsprintf(). This can't actually
overflow in practice, since we only format a very tame
subset of strings (mostly strerror() output). However, it's
hard to tell immediately, so let's just use a strbuf so
readers do not have to wonder.
We do add an allocation here, but the performance is not
important; the next step is to call die() anyway.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/upload-archive.c | diffblobblamehistory |