From 95cc5ee4dc652f51221e04f7e360adca29bd4cd4 Mon Sep 17 00:00:00 2001 From: Nicola Fontana Date: Wed, 23 Jun 2010 20:25:57 +0200 Subject: [PATCH] [AdgCanvas] Corrected margins and paddings low limit G_MINDOUBLE is the value closest to 0, not the minimum negative double, as the damned name suggests. Changed the low limit to -G_MAXDOUBLE. --- src/adg/adg-canvas.c | 16 ++++++++-------- src/adg/tests/test-canvas.c | 16 ++++++++-------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/adg/adg-canvas.c b/src/adg/adg-canvas.c index 834ee021..5e321403 100644 --- a/src/adg/adg-canvas.c +++ b/src/adg/adg-canvas.c @@ -164,28 +164,28 @@ adg_canvas_class_init(AdgCanvasClass *klass) param = g_param_spec_double("top-margin", P_("Top Margin"), P_("The margin (in identity space) to leave above the frame"), - G_MINDOUBLE, G_MAXDOUBLE, 15, + -G_MAXDOUBLE, G_MAXDOUBLE, 15, G_PARAM_READWRITE); g_object_class_install_property(gobject_class, PROP_TOP_MARGIN, param); param = g_param_spec_double("right-margin", P_("Right Margin"), P_("The margin (in identity space) to leave empty at the right of the frame"), - G_MINDOUBLE, G_MAXDOUBLE, 15, + -G_MAXDOUBLE, G_MAXDOUBLE, 15, G_PARAM_READWRITE); g_object_class_install_property(gobject_class, PROP_RIGHT_MARGIN, param); param = g_param_spec_double("bottom-margin", P_("Bottom Margin"), P_("The margin (in identity space) to leave empty below the frame"), - G_MINDOUBLE, G_MAXDOUBLE, 15, + -G_MAXDOUBLE, G_MAXDOUBLE, 15, G_PARAM_READWRITE); g_object_class_install_property(gobject_class, PROP_BOTTOM_MARGIN, param); param = g_param_spec_double("left-margin", P_("Left Margin"), P_("The margin (in identity space) to leave empty at the left of the frame"), - G_MINDOUBLE, G_MAXDOUBLE, 15, + -G_MAXDOUBLE, G_MAXDOUBLE, 15, G_PARAM_READWRITE); g_object_class_install_property(gobject_class, PROP_LEFT_MARGIN, param); @@ -199,28 +199,28 @@ adg_canvas_class_init(AdgCanvasClass *klass) param = g_param_spec_double("top-padding", P_("Top Padding"), P_("The padding (in identity space) to leave empty above between the drawing and the frame"), - G_MINDOUBLE, G_MAXDOUBLE, 15, + -G_MAXDOUBLE, G_MAXDOUBLE, 15, G_PARAM_READWRITE); g_object_class_install_property(gobject_class, PROP_TOP_PADDING, param); param = g_param_spec_double("right-padding", P_("Right Padding"), P_("The padding (in identity space) to leave empty at the right between the drawing and the frame"), - G_MINDOUBLE, G_MAXDOUBLE, 15, + -G_MAXDOUBLE, G_MAXDOUBLE, 15, G_PARAM_READWRITE); g_object_class_install_property(gobject_class, PROP_RIGHT_PADDING, param); param = g_param_spec_double("bottom-padding", P_("Bottom Padding"), P_("The padding (in identity space) to leave empty below between the drawing and the frame"), - G_MINDOUBLE, G_MAXDOUBLE, 15, + -G_MAXDOUBLE, G_MAXDOUBLE, 15, G_PARAM_READWRITE); g_object_class_install_property(gobject_class, PROP_BOTTOM_PADDING, param); param = g_param_spec_double("left-padding", P_("Left Padding"), P_("The padding (in identity space) to leave empty at the left between the drawing and the frame"), - G_MINDOUBLE, G_MAXDOUBLE, 15, + -G_MAXDOUBLE, G_MAXDOUBLE, 15, G_PARAM_READWRITE); g_object_class_install_property(gobject_class, PROP_LEFT_PADDING, param); } diff --git a/src/adg/tests/test-canvas.c b/src/adg/tests/test-canvas.c index 72f165e0..f9f6fce4 100644 --- a/src/adg/tests/test-canvas.c +++ b/src/adg/tests/test-canvas.c @@ -210,7 +210,7 @@ _adg_test_top_margin(void) canvas = ADG_CANVAS(adg_canvas_new()); valid_value_1 = 4321; - valid_value_2 = 1234; + valid_value_2 = -1; /* Using the public APIs */ adg_canvas_set_top_margin(canvas, valid_value_1); @@ -242,7 +242,7 @@ _adg_test_right_margin(void) canvas = ADG_CANVAS(adg_canvas_new()); valid_value_1 = 4321; - valid_value_2 = 1234; + valid_value_2 = 0; /* Using the public APIs */ adg_canvas_set_right_margin(canvas, valid_value_1); @@ -274,7 +274,7 @@ _adg_test_bottom_margin(void) canvas = ADG_CANVAS(adg_canvas_new()); valid_value_1 = 4321; - valid_value_2 = 1234; + valid_value_2 = -1234; /* Using the public APIs */ adg_canvas_set_bottom_margin(canvas, valid_value_1); @@ -306,7 +306,7 @@ _adg_test_left_margin(void) canvas = ADG_CANVAS(adg_canvas_new()); valid_value_1 = 4321; - valid_value_2 = 1234; + valid_value_2 = -4321; /* Using the public APIs */ adg_canvas_set_left_margin(canvas, valid_value_1); @@ -377,7 +377,7 @@ _adg_test_top_padding(void) canvas = ADG_CANVAS(adg_canvas_new()); valid_value_1 = 4321; - valid_value_2 = 1234; + valid_value_2 = 0; /* Using the public APIs */ adg_canvas_set_top_padding(canvas, valid_value_1); @@ -409,7 +409,7 @@ _adg_test_right_padding(void) canvas = ADG_CANVAS(adg_canvas_new()); valid_value_1 = 4321; - valid_value_2 = 1234; + valid_value_2 = -1; /* Using the public APIs */ adg_canvas_set_right_padding(canvas, valid_value_1); @@ -441,7 +441,7 @@ _adg_test_bottom_padding(void) canvas = ADG_CANVAS(adg_canvas_new()); valid_value_1 = 4321; - valid_value_2 = 1234; + valid_value_2 = -4321; /* Using the public APIs */ adg_canvas_set_bottom_padding(canvas, valid_value_1); @@ -473,7 +473,7 @@ _adg_test_left_padding(void) canvas = ADG_CANVAS(adg_canvas_new()); valid_value_1 = 4321; - valid_value_2 = 1234; + valid_value_2 = -1111; /* Using the public APIs */ adg_canvas_set_left_padding(canvas, valid_value_1); -- 2.11.4.GIT