From 9457b7ea2214aaa3a466e5dbc2daa0b931975073 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Wed, 10 Mar 2010 15:56:13 +1100 Subject: [PATCH] s4:libcli/resolve Use a more robust way to return the string address By going via these tevent functions, we avoid needing to dereference the struct socket_address, which may contain a 'struct sockaddr' or strings. The new dns_host_file resolver returns in the form of a struct sockaddr. Andrew Bartlett --- source4/libcli/config.mk | 2 +- source4/libcli/resolve/resolve.c | 13 +++++++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/source4/libcli/config.mk b/source4/libcli/config.mk index 716e23b60d7..246abd414a0 100644 --- a/source4/libcli/config.mk +++ b/source4/libcli/config.mk @@ -65,7 +65,7 @@ LIBCLI_WREPL_OBJ_FILES = $(libclisrcdir)/wrepl/winsrepl.o $(eval $(call proto_header_template,$(libclisrcdir)/wrepl/winsrepl_proto.h,$(LIBCLI_WREPL_OBJ_FILES:.o=.c))) [SUBSYSTEM::LIBCLI_RESOLVE] -PUBLIC_DEPENDENCIES = NDR_NBT +PUBLIC_DEPENDENCIES = NDR_NBT LIBTSOCKET LIBCLI_RESOLVE_OBJ_FILES = $(libclisrcdir)/resolve/resolve.o diff --git a/source4/libcli/resolve/resolve.c b/source4/libcli/resolve/resolve.c index 0ad3a75e893..77f7f4f46bd 100644 --- a/source4/libcli/resolve/resolve.c +++ b/source4/libcli/resolve/resolve.c @@ -27,6 +27,7 @@ #include "system/network.h" #include "lib/socket/socket.h" #include "../lib/util/dlinklist.h" +#include "lib/tsocket/tsocket.h" struct resolve_state { struct resolve_context *ctx; @@ -145,7 +146,7 @@ struct composite_context *resolve_name_all_send(struct resolve_context *ctx, struct composite_context *c; struct resolve_state *state; - if (ctx == NULL || event_ctx == NULL) { + if (event_ctx == NULL) { return NULL; } @@ -239,8 +240,16 @@ NTSTATUS resolve_name_recv(struct composite_context *c, status = resolve_name_all_recv(c, mem_ctx, &addrs, NULL); if (NT_STATUS_IS_OK(status)) { - *reply_addr = talloc_steal(mem_ctx, addrs[0]->addr); + struct tsocket_address *t_addr = socket_address_to_tsocket_address(addrs, addrs[0]); + if (!t_addr) { + return NT_STATUS_NO_MEMORY; + } + + *reply_addr = tsocket_address_inet_addr_string(t_addr, mem_ctx); talloc_free(addrs); + if (!*reply_addr) { + return NT_STATUS_NO_MEMORY; + } } return status; -- 2.11.4.GIT