| commit | 2cf83f7c645e4b216cf6f23857fd72ec0e6ca7a6 | |
| author | Andrew Bartlett <abartlet@samba.org> | |
| Sun, 17 Feb 2013 07:15:52 +0000 (17 18:15 +1100) | ||
| committer | Andrew Bartlett <abartlet@samba.org> | |
| Tue, 19 Feb 2013 06:48:18 +0000 (19 07:48 +0100) | ||
| tree | 4df530c67e111ee4982b08b4df1d1e9767d38ba6 | treesnapshot (tar.gz zip) |
| parent | 3c51e18a0cd1cb4b54cd29e312abd7cc2c0fbc98 | commitdiff |
samba_upgradeprovision: Use tdb_util.tdb_copy not shutil.copy2
This is really important, because copying a file will both ignore
locks held by another process and break any locks we hold (due to
POSIX brain-damage regarding multiple fds on one file in a process).
By leaving this to tdbbackup in a child, both of these issues are avoided.
Andrew Bartlett
Reviewed-by: Matthieu Patou <mat@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Feb 19 07:48:18 CET 2013 on sn-devel-104
This is really important, because copying a file will both ignore
locks held by another process and break any locks we hold (due to
POSIX brain-damage regarding multiple fds on one file in a process).
By leaving this to tdbbackup in a child, both of these issues are avoided.
Andrew Bartlett
Reviewed-by: Matthieu Patou <mat@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Feb 19 07:48:18 CET 2013 on sn-devel-104
| source4/scripting/bin/samba_upgradeprovision | diffblobblamehistory |