From d4168fce7b07f417c81c801da0fd664fbb90715a Mon Sep 17 00:00:00 2001
From: =?utf8?q?Bj=C3=B6rn=20Jacke?= <bjacke@samba.org>
Date: Mon, 25 Dec 2023 20:30:43 +0100
Subject: [PATCH] s4/ldap_backend: fix a NULL dereference

Signed-off-by: Bjoern Jacke <bjacke@samba.org>>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---
 source4/ldap_server/ldap_backend.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/source4/ldap_server/ldap_backend.c b/source4/ldap_server/ldap_backend.c
index 4e94417c21b..3bcd984f149 100644
--- a/source4/ldap_server/ldap_backend.c
+++ b/source4/ldap_server/ldap_backend.c
@@ -288,14 +288,15 @@ static NTSTATUS ldapsrv_encode(TALLOC_CTX *mem_ctx,
 				samba_ldap_control_handlers(),
 				&reply->blob,
 				mem_ctx);
-	TALLOC_FREE(reply->msg);
 	if (!bret) {
 		DEBUG(0,("Failed to encode ldap reply of type %d: "
 			 "ldap_encode() failed\n",
 			 reply->msg->type));
+		TALLOC_FREE(reply->msg);
 		return NT_STATUS_NO_MEMORY;
 	}
 
+	TALLOC_FREE(reply->msg);
 	talloc_set_name_const(reply->blob.data,
 			      "Outgoing, encoded single LDAP reply");
 
-- 
2.11.4.GIT