From c253f956ef0b40a8d1d877acfd5da9d27ec0d0b4 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Sun, 1 Mar 2015 20:00:05 +1300 Subject: [PATCH] smb.conf.5: Mark "dgram port" and "nbt port" as deprecated These are not honored in the source3 codebase, so keeping them is confusing. Signed-off-by: Andrew Bartlett Reviewed-by: Jelmer Vernooij BUG: https://bugzilla.samba.org/show_bug.cgi?id=11126 --- docs-xml/smbdotconf/protocol/dgramport.xml | 3 ++- docs-xml/smbdotconf/protocol/nbtport.xml | 2 ++ lib/param/param_table.c | 6 ++++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/docs-xml/smbdotconf/protocol/dgramport.xml b/docs-xml/smbdotconf/protocol/dgramport.xml index ee10e9c2d3d..a90310dcb55 100644 --- a/docs-xml/smbdotconf/protocol/dgramport.xml +++ b/docs-xml/smbdotconf/protocol/dgramport.xml @@ -6,6 +6,7 @@ Specifies which ports the server should listen on for NetBIOS datagram traffic. - +This parameter is deprecated, as it is not honoured in the +majority of the code base. 138 diff --git a/docs-xml/smbdotconf/protocol/nbtport.xml b/docs-xml/smbdotconf/protocol/nbtport.xml index 1d99270b81b..f7ec1e72973 100644 --- a/docs-xml/smbdotconf/protocol/nbtport.xml +++ b/docs-xml/smbdotconf/protocol/nbtport.xml @@ -8,5 +8,7 @@ services traffic. +This parameter is deprecated, as it is not honoured in the +majority of the code base. 137 diff --git a/lib/param/param_table.c b/lib/param/param_table.c index 00274ca2cbd..3437234c766 100644 --- a/lib/param/param_table.c +++ b/lib/param/param_table.c @@ -1707,7 +1707,8 @@ struct parm_struct parm_table[] = { .p_class = P_GLOBAL, .offset = GLOBAL_VAR(dgram_port), .special = NULL, - .enum_list = NULL + .enum_list = NULL, + .flags = FLAG_DEPRECATED }, { .label = "nbt port", @@ -1715,7 +1716,8 @@ struct parm_struct parm_table[] = { .p_class = P_GLOBAL, .offset = GLOBAL_VAR(nbt_port), .special = NULL, - .enum_list = NULL + .enum_list = NULL, + .flags = FLAG_DEPRECATED }, { .label = "krb5 port", -- 2.11.4.GIT